Update Job status display to actually use job status #10245
Draft
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jnoordsij The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6443 (or at least partially).
Currently the state indicator of jobs in the resource list (
/#/job) always seems to be green on my end, with tooltipRunning, even when the actual jobs have either failed or succeeded. This is somewhat confusing in terms of UX/UI.This PR aims to update the job status to actually reflect the state of the job, matching with the available types I traced in the api module:
dashboard/modules/api/pkg/resource/job/list.go
Lines 46 to 55 in 010e944
Note: I have not yet been able to actually test this, hence this is still a draft. If there's already feedback on how to approach this, please let me know! Also feel free to take over/follow up on this.